chore: re-introduce node v14 compatibiliy, bump deps #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
floydspace
approved these changes
Dec 27, 2022
|
@dnalborczyk thank you for your contribution, it makes sense. I made fixes in the e2e tests and ci/cd required to make it work. |
|
🎉 This PR is included in version 1.35.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
thank you for picking this up @floydspace ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we have some scenario tests running in the
serverless-offlinerepository withserverless-esbuild. bumping esbuild tov0.15.13+results into the tests hanging. this was fixed in 0.16.3: evanw/esbuild#2727unfortunately
esbuild-node-externalshas a peer dependency on 0.15 as well, which ideally would need to be fixed prior: pradel/esbuild-node-externals#35we can wait and introduce esbuild v0.16 compat in a follow-up PR.