Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] Update flow-bin to 0.200.0 #4547

Merged
merged 6 commits into from Oct 29, 2023
Merged

Conversation

Brianzchen
Copy link
Member

Update flow-bin to a newer version, at this version local type annotations becomes a requirement and a more checks such as if a variable is declared as string it cannot be reassigned as number.

Current version is 0.220.0 and will upgrade to that incrementally, the changes are quite large

Copy link
Member

@pascalduez pascalduez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests where failing, but I couldn't spot an issue from the diff, I've re-run them, they seem highly volatile.

EDIT: and now they pass...

@Brianzchen
Copy link
Member Author

Tests where failing, but I couldn't spot an issue from the diff, I've re-run them, they seem highly volatile.

yeah we used to have that issue where flow definition runs were flakey.. Now issue with unit test suite but usually passes after first run.

@Brianzchen Brianzchen merged commit 8a67a35 into flow-typed:main Oct 29, 2023
4 checks passed
@Brianzchen Brianzchen deleted the flow-update branch October 29, 2023 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants