[cli] Install a dependency's environment definitions #4541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gantoine
approved these changes
Oct 24, 2023
Yep thats right! Test prove that at least :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4445. For any dependency that ships flow type definitions check if they have a
flow-typed.config.jsonand if so, read theirenvto check if they depend on any environment definitions.If so install them along side any environment definitions the project installing might need. This allows a library to be developed with flow-typed knowing it will behave the same when consumed by a consumer using flow.
Not very common for open source, but very useful when developing a stack of internal npm libraries all shipping flow types.