Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cli] pnpm support #4540

Merged
merged 7 commits into from Oct 23, 2023
Merged

[cli] pnpm support #4540

merged 7 commits into from Oct 23, 2023

Conversation

Brianzchen
Copy link
Member

Closes #4484. This change does 2 key things

  • Scan pnpm-workspace.yaml for package globs to find workspaces when creating a dependency list to map to flow-typed definitions
  • And not stubbing dependencies when a library ships with type definitions but the dependency sits in a workspace's node_modules instead of in the root node_modules. This is default behaviour for pnpm so previously would cause stubs to constantly get installed even if a workspace dependency shipped type defs. This could also be an issue for yarn or any other package manager if they used the noHoist option.

gantoine
gantoine approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@gantoine gantoine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@Brianzchen Brianzchen merged commit b30ed37 into flow-typed:main Oct 23, 2023
4 checks passed
@Brianzchen Brianzchen deleted the pnpm-support branch October 23, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gantoine gantoine gantoine approved these changes

@pascalduez pascalduez Awaiting requested review from pascalduez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Brianzchen @gantoine