Drop duplicate declaration of lodash-es/create module #4430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In current versions of Flow this duplicate cause flow to crash with "Should have been excluded: .$module__lodash-es/create" I found the log entry when running flow server with --temp-dir flag and looking at the log file generated in this temp dir: Unhandled exception: (Failure "Should have been excluded: .$module__lodash-es/create") Raised at Stdlib.failwith in file "stdlib.ml", line 29, characters 17-33 Called from Env.init_builtins_from_libdef.(fun) in file "src/typing/env.ml", line 917, characters 6-35
|
Oops! That's my bad, will merge once green |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In current versions of Flow this duplicate cause flow to crash with "Should have been excluded: .$module__lodash-es/create"
I found the log entry when running flow server with --temp-dir flag and looking at the log file generated in this temp dir:
Unhandled exception: (Failure "Should have been excluded: .$module__lodash-es/create") Raised at Stdlib.failwith in file "stdlib.ml", line 29, characters 17-33 Called from Env.init_builtins_from_libdef.(fun) in file "src/typing/env.ml", line 917, characters 6-35