[use-clipboard-copy_v0.1.x] Flow >= 0.203 upgrade #4429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pascalduez
force-pushed
the
feature/use-clipboard-copy/lti
branch
2 times, most recently
from
0cf24ec
to
52a4e7a
Compare
pascalduez
force-pushed
the
feature/use-clipboard-copy/lti
branch
from
52a4e7a
to
be0f55c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other notes:
Flow LTI upgrade, which is activated by default starting from
0.201.If we want to preserve a default signature without forcing passing parameters, we need to set a default, which can be quite touchy, here decided on
HTMLElementwhich gives a pretty good type by default, if a user needs more, they can pass a type. It needed to be compatible with React codereftyping as well.