@sentry/browser root captureException & captureMessage arg types update #4211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
captureMessage & captureException exist on the root of Sentry and also at the Hub level. We currently type all instances as if they were on the Hub. https://getsentry.github.io/sentry-javascript/interfaces/types.hub-1.html#captureexception This updates the root captureMessage/Exception arguments: https://getsentry.github.io/sentry-javascript/modules/minimal.html#captureexception
emcelyea
changed the title
|
Looks like some tests have failed, they could be fixed but also some additional tests to secure your work would be great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
captureMessage & captureException exist on the root of Sentry and also at the Hub & Scope level. We currently type all instances as if they were Hub.captureException instead of Sentry.captureException.
Hub captureException docs:
https://getsentry.github.io/sentry-javascript/interfaces/types.hub-1.html#captureexception
root captureException docs:
https://getsentry.github.io/sentry-javascript/modules/minimal.html#captureexception
This updates the root captureMessage/Exception arguments: