Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] New outdated command #4171

Merged
merged 16 commits into from Feb 6, 2022
Merged

Conversation

Brianzchen
Copy link
Member

@Brianzchen Brianzchen commented Nov 23, 2021

Closes #2077. User can run flow-typed outdated to render a cli table letting the user know which deps are outdated.

  • Either the lib def was a stub but is now typed
  • Or it was typed but there's been a change checking whether the libdef signature has changed

Screen Shot 2022-02-04 at 6 30 47 am

Notes on extra changes:

  • Added test:watch script to easily tweak changes
  • determineFlowVersion renamed to determineFlowSpecificVersion to avoid name conflict and shift to lib for reuse with outdated command

@AndrewSouthpaw
Copy link
Contributor

Seems pretty useful! What else needs to be done for this to not be a WIP?

@Brianzchen
Copy link
Member Author

Seems pretty useful! What else needs to be done for this to not be a WIP?

The comment blocks if you read the command basically outlines all the places I still haven't figured out yet. It's definitely a fun change imo but I've just been preoccupied with other stuff. Given the complexity vs the value I've just put a much lower priority on this so far.

Also it'll need tests which shouldn't be too difficult once the change is done.

@Brianzchen
Copy link
Member Author

Only have tests remaining!

@Brianzchen Brianzchen changed the title [cli] New outdated command (WIP) [cli] New outdated command Feb 4, 2022
@Brianzchen Brianzchen merged commit da69682 into flow-typed:master Feb 6, 2022
@Brianzchen Brianzchen deleted the cli-outdated branch February 6, 2022 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New CLI command: outdated
3 participants