New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create sequelize 5/6 defs #3981
base: master
Are you sure you want to change the base?
Conversation
Not to my knowledge, short of just hacking the CLI code. |
@jedwards1211 since this is mostly a copy-pasta job, I'm fine with merging if you've poked it enough to be satisfied. |
Actually let's wait. I'm changing a bunch of stuff over to exact objects and spreads. |
Sounds good! Let me know when you're ready. |
@jedwards1211 any news on this? |
We too are in need of these - anything we can do to help @jedwards1211? Even a rough outline of the exact objects or spread changes you were thinking about would point us in the right direction. |
@dannyjlaurence-exp As far as I can tell these are new definitions which doesn't break anything existing. There's also tests in place to an extent. If you can give us some peace of mind that these defs are useful to you, I think we can merge and improve later. Considering also this PR is 2 years old it may be very outdated against current versions of flow |
Other notes:
I copied over the flow_v0.42.x-v0.103.x folders and applied the same changes to them, but I honestly haven't tested them. (Is there a way to tell run_tests what versions of flow to use?)