Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create sequelize 5/6 defs #3981

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

jedwards1211
Copy link
Contributor

@AndrewSouthpaw
Copy link
Contributor

Is there a way to tell run_tests what versions of flow to use?

Not to my knowledge, short of just hacking the CLI code.

@AndrewSouthpaw
Copy link
Contributor

@jedwards1211 since this is mostly a copy-pasta job, I'm fine with merging if you've poked it enough to be satisfied.

@jedwards1211
Copy link
Contributor Author

Actually let's wait. I'm changing a bunch of stuff over to exact objects and spreads.

@AndrewSouthpaw
Copy link
Contributor

Sounds good! Let me know when you're ready.

@Brianzchen
Copy link
Member

@jedwards1211 any news on this?

@dannyjlaurence-exp
Copy link

We too are in need of these - anything we can do to help @jedwards1211? Even a rough outline of the exact objects or spread changes you were thinking about would point us in the right direction.

@Brianzchen
Copy link
Member

Brianzchen commented Feb 6, 2023

@dannyjlaurence-exp As far as I can tell these are new definitions which doesn't break anything existing. There's also tests in place to an extent. If you can give us some peace of mind that these defs are useful to you, I think we can merge and improve later.

Considering also this PR is 2 years old it may be very outdated against current versions of flow

@gantoine gantoine added the changes requested Changes have been requested by a reviewer label May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes requested Changes have been requested by a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants