[moment_v2.x.x] Support moment v2.25 strict string parsing feature #3832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous locations for $ExpectError in these tests hid too many errors and more modern Flow versions no longer accepted that.
valscion
commented
May 12, 2020
| @@ -169,6 +175,12 @@ declare class moment$Moment { | |||
| | void | |||
| ): moment$Moment; | |||
| static utc(string: string, format: string | Array<string>): moment$Moment; | |||
| static utc( | |||
| string: string, | |||
There was a problem hiding this comment.
It was a bit odd to see that moment() constructor made the first string argument be optional with ?string but moment.utc didn't.
Seems like #2875 did not do the changes for moment.utc constructor. If this is something that we'd want to have in flow-typed, I can do that in another PR — but it is not in the scope of this PR, in my opinion.
AndrewSouthpaw
approved these changes
Jun 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other notes:
In moment v2.25, constructing a
Momentobject viamoment(someString, true)got allowed.Note that this PR intentionally does not fork the
momenttype declarations on themoment_v2.25.xversion boundary. Forking would make updating these type declarations a pain in the future.Hopefully the small comments I left in the type declarations will help users that aren't running
momentv2.25 yet to understand that the new API would not work for them.