Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] add three 0.112.x #3687

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mcharytoniuk
Copy link

Other notes:
Types list is not complete, but it's definitely more comprehensive than existing 0.98.x types. I preserved most types from 0.98 as is, but also added generics for types like Mesh (Mesh<T: BufferGeometry | Geometry, U: Material>).

I didn't write explicit tests for types because I just didn't know there were tools for testing flow types. It seems too much work for me at the moment to write all those tests at once, so I am submitting those types as [WIP]. I will be still actively working on those to complete definitions and add test coverage, but I'd happily welcome any kind of help.

Copy link
Contributor

@AndrewSouthpaw AndrewSouthpaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

You're going to need to correct the Travis errors. Mostly they appear to be around fixing the inexact object types:

   Please add `...` to the end of the list of properties to express an inexact object type. (`implicit-inexact-object`)
    
                                           v
       181|   declare type ShaderDefines = {
       182|     [string]: string,
       183|   };

and so on.

@gantoine gantoine added the changes requested Changes have been requested by a reviewer label Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes requested Changes have been requested by a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants