Add moment-timezone types definition #3577
Open
+152
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pascalduez
requested changes
Sep 28, 2019
There was a problem hiding this comment.
You'll need to write tests.
Check the contributing guidelines
definitions/npm/moment-timezone_v2.x.x/flow_v0.104.x-/moment-timezone_v2.x.x.js
Outdated
Show resolved
Hide resolved
definitions/npm/moment-timezone_v2.x.x/flow_v0.104.x-/moment-timezone_v2.x.x.js
Outdated
Show resolved
Hide resolved
|
@pascalduez will add some test cases later. |
GrapFinanceDev
changed the title
GrapFinanceDev
changed the title
|
@pascalduez update import problem now. |
pascalduez
reviewed
Oct 22, 2019
| * Flowgen v1.10.0 | ||
| */ | ||
|
|
||
| import * as moment from "moment-timezone"; |
|
Still missing tests. |
|
If this definition is to some day get merged, the definition shouldn't be built on flow-gen I believe. It's just way too confusing. From what I understand Also the definition should target package version 0.5.x not 2.x.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found out we don't have moment-timezone's type definition.