Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[lodash_v4.x.x] lodash.values generic parameters #3005

Closed
wants to merge 5 commits into from
Closed

[lodash_v4.x.x] lodash.values generic parameters #3005

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3ece85a
Generic typed for values
beaucollins Dec 13, 2018
5178adc
Merge branch 'master' of github.com:flow-typed/flow-typed
beaucollins Dec 19, 2018
2142d4c
Merge branch 'master' of github.com:flow-typed/flow-typed
beaucollins Dec 19, 2018
7148f54
Merge remote-tracking branch 'origin/master'
beaucollins Jan 3, 2019
81d6c2d
Unit test for values with indexed type
beaucollins Jan 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions definitions/npm/lodash_v4.x.x/flow_v0.63.x-/lodash_v4.x.x.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1302,6 +1302,7 @@ declare module "lodash" {
updater?: ?Function,
customizer?: ?Function
): T;
values<K, V>(object?: ?{[K]: V}): Array<V>;
values(object?: ?Object): Array<any>;
valuesIn(object?: ?Object): Array<any>;

Expand Down
7 changes: 7 additions & 0 deletions definitions/npm/lodash_v4.x.x/flow_v0.63.x-/test_lodash-v4.x.x.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ import toPairs from "lodash/toPairs";
import toPairsIn from "lodash/toPairsIn";
import unionBy from "lodash/unionBy";
import uniqBy from "lodash/uniqBy";
import values from "lodash/values";
import xorBy from "lodash/xorBy";
import zip from "lodash/zip";
import zipWith from "lodash/zipWith";
Expand Down Expand Up @@ -502,3 +503,9 @@ pairs = toPairsIn({ a: 12, b: 100 });
(omitBy(null, num => num % 2): {});
(omitBy(undefined, num => num % 2): {});
(omitBy({ [1]: 1, [2]: 2 }, num => num === 2): { [prop: number]: number });

/**
* _.values
*/
// $ExpectError values retains the type of value
(values(({ a: 2 }: {[string]: number })): Array<string>);