[react-apollo] Extract QueryComponentProps #2820
Conversation
As a user of `react-apollo`, it's a common use case to want to create your own higher-order `Query` component to specify default options, additional behaviours, etc. In order to type that higher order component, we need to export the Props type of the `react-apollo` `Query` component, so that a consumer of the library can use it to define their HoC props type by extending it. This commit extracts and exports a generic `QueryComponentProps<TData, TVariables>` type. It has no functional changes.
|
The failing Travis test does not seem to be related to this change -- it's a failing test for regression #1385. |
|
@jevakallio Thanks for the contribution! I rerun the test suite and looks like there are bunch of valid errors too. |
gantoine
added
enhancement
|
ping on this? flow is failing for all the teams I work with that use react-apollo. |
|
@matthargett feel free to fork and reopen the PR with fixed test cases. I'm afraid that the original author is no longer interested in this. |
|
Hi, I'm sorry, I'm still interested in this, but I haven't had time to follow up on it since I'm no longer working in that codebase and using Flow, and I don't have a meaningful local test case to drive it. @matthargett if you can pick this up that would be fantastic -- if not, I can try to address the issues when I get a chance. Let me know. |
|
@jevakallio any progress? :) |
As a user of
react-apollo, it's a common use case to want to create your own higher-orderQuerycomponent to specify default options, additional behaviours, etc.In order to type that higher order component, we need to export the Props type of the
react-apolloQuerycomponent, so that a consumer of the library can use it to define their HoC props type by extending it.This commit extracts and exports a generic
QueryComponentProps<TData, TVariables>type. It has no functional changes.