Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade download flow #2193

Closed
wants to merge 5 commits into from
Closed

Upgrade download flow #2193

wants to merge 5 commits into from

Conversation

XaveScor
Copy link
Contributor

@XaveScor XaveScor commented May 9, 2018

Changes:

  1. Zip archives download to memory instead of disk. Only binary file writes to disk.
  2. Downloaded only versions with latest patch. For example, 0.53.0, 0.53.1, 0.53.2 will be not checked. Only 0.53.3.
  3. Total refactoring of download process.

@XaveScor
Copy link
Contributor Author

XaveScor commented May 9, 2018

Please create oauth key and add to travis ci. My tests will be passed.
https://travis-ci.org/XaveScor/flow-typed/jobs/377003760 https://travis-ci.org/XaveScor/flow-typed/jobs/377003761

@AndrewSouthpaw
Copy link
Contributor

cc @gantoine

@gantoine
Copy link
Member

Please create oauth key and add to travis ci.

I'm not sure what you mean by that. Could you elaborate?

@gantoine gantoine self-assigned this May 12, 2018
@gantoine gantoine added enhancement An addition to an existing component needs updates The PR needs updates before shipping (eg. failing build, bad file path) cli Related to CLI tool labels May 12, 2018
@XaveScor
Copy link
Contributor Author

XaveScor commented May 12, 2018 •
edited

I'm not sure what you mean by that. Could you elaborate?

API rate limit exceeded for 52.3.55.28. libs/github.js contains GH_TOK env variable for remove limits to GitHub API calls. You need to add GH_TOK to travisCI. You can get it here

@XaveScor
Copy link
Contributor Author

@gantoine?

@gantoine
Copy link
Member

@XaveScor Sorry, I've been busy with work, I'll get around to this soon.

@XaveScor XaveScor mentioned this pull request May 17, 2018
Open
@XaveScor
Copy link
Contributor Author

XaveScor commented Jun 7, 2018

up

@villesau
Copy link
Member

@XaveScor @gantoine what is the status of this?

@gantoine gantoine closed this May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gantoine gantoine Awaiting requested review from gantoine

Assignees

@gantoine gantoine

Labels
cli Related to CLI tool enhancement An addition to an existing component needs updates The PR needs updates before shipping (eg. failing build, bad file path)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@XaveScor @AndrewSouthpaw @gantoine @villesau