Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install defs from node_modules/<package>/flow-self-typed if it exists for each package #1435

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Commits on Dec 4, 2017

  1. feature: install defs from node_modules/<package>/flow-typed if it ex…

    …ists for each package
    
    This is a workaround for facebook/flow#4917.
    
    **Note**: self-provided defs will only be found for packages that are already installed in `node_modules`!
    It also enables package authors to update their type defs without having to make PRs to `flow-typed`.
    If an installed package provides its own `flow-typed` directory it will override anything in `flow-typed`'s central repo.
    
    ### Directory structure
    A package's `flow-typed` directory has the same structure as `flow-typed/definitions/npm/<package>_v<version>/` would,
    except that the `.js` files must use the exact version of the package:
    ```
    node_modules/underscore/
      flow-typed/
        flow_v0.13.x-v0.37.x/
          underscore_v1.8.3.js
        flow_v0.38.x-/
          underscore_v1.8.3.js
    ```
    jedwards1211 committed Dec 4, 2017
    Configuration menu
    Copy the full SHA
    0734a13 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a18a469 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0c88879 View commit details
    Browse the repository at this point in the history
  4. another fix

    jedwards1211 committed Dec 4, 2017
    Configuration menu
    Copy the full SHA
    0370dc3 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    c1b7c1a View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    169153e View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2017

  1. Configuration menu
    Copy the full SHA
    c70f162 View commit details
    Browse the repository at this point in the history