fix: Improve placement of $FlowExpectedErrors (#4559)

flow-typed · Dec 19, 2023 · 87f1dca · 87f1dca
1 parent 3381fb8
commit 87f1dca
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 8 deletions.
diff --git a/definitions/npm/@babel/polyfill_v7.x.x/flow_v0.104.x-/test_polyfill_v7.x.x.js b/definitions/npm/@babel/polyfill_v7.x.x/flow_v0.104.x-/test_polyfill_v7.x.x.js
@@ -4,5 +4,5 @@ import '@babel/polyfill';
 // This should fail but couldn't make it to do so
 import defaultValue from '@babel/polyfill';
 
-// $FlowExpectedError does not export anything
+// $FlowExpectedError[missing-export] does not export anything
 import { namedExport } from '@babel/polyfill';
diff --git a/definitions/npm/@babel/polyfill_v7.x.x/flow_v0.30.x-v0.103.x/test_polyfill_v7.x.x.js b/definitions/npm/@babel/polyfill_v7.x.x/flow_v0.30.x-v0.103.x/test_polyfill_v7.x.x.js
@@ -4,5 +4,5 @@ import '@babel/polyfill';
 // This should fail but couldn't make it to do so
 import defaultValue from '@babel/polyfill';
 
-// $FlowExpectedError does not export anything
+// $FlowExpectedError[missing-export] does not export anything
 import { namedExport } from '@babel/polyfill';
diff --git a/definitions/npm/@babel/register_v7.x.x/flow_v0.104.x-/test_register_v7.x.x.js b/definitions/npm/@babel/register_v7.x.x/flow_v0.104.x-/test_register_v7.x.x.js
@@ -3,7 +3,7 @@ import { describe, it } from 'flow-typed-test';
 
 describe('unknown properties', () => {
   it('are not allowed', () => {
-    // $FlowExpectedError does not accept unknown props
+    // $FlowExpectedError[prop-missing] does not accept unknown props
     require('@babel/register')({
       unknown: 'property'
     });
@@ -20,14 +20,12 @@ describe('plugins', () => {
     });
   });
   it('does not accept anything else', () => {
-    // $FlowExpectedError no numbers
     require('@babel/register')({
-      plugins: [
-        123
-      ]
+      // $FlowExpectedError[incompatible-call] no numbers
+      plugins: [123]
     });
-    // $FlowExpectedError should be array
     require('@babel/register')({
+      // $FlowExpectedError[incompatible-call] should be array
       plugins: 'my-plugin'
     });
   })