Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] RDoc for additions #548

Closed
wants to merge 9 commits into from
Closed

[DOC] RDoc for additions #548

wants to merge 9 commits into from

Conversation

BurdetteLamar
Copy link
Contributor

@BurdetteLamar BurdetteLamar commented Nov 16, 2023

I realized in working with BigDecimal here that the user is most like to pair the serialize/deserialize operations, so have written accordingly.

@BurdetteLamar BurdetteLamar marked this pull request as draft November 21, 2023 21:08
@BurdetteLamar BurdetteLamar marked this pull request as ready for review November 25, 2023 21:07
@BurdetteLamar
Copy link
Contributor Author

@hsbt, I don't think I caused these failed checks, but please correct me if I'm wrong.

@BurdetteLamar
Copy link
Contributor Author

@hsbt, @nurse: Will either of you be reviewing this? If not, is there someone else I should ask?

@hsbt
Copy link
Collaborator

hsbt commented Dec 1, 2023

@BurdetteLamar I exclude truffleruby-head from CI at #551. You can resolve CI failure with git rebase.

@BurdetteLamar
Copy link
Contributor Author

@BurdetteLamar I exclude truffleruby-head from CI at #551. You can resolve CI failure with git rebase.

@hsbt, I was not able to do this. Can you (or someone else) resolve this?

@BurdetteLamar
Copy link
Contributor Author

As I said earlier, I was not able to untangle this PR. If no one objects, I'll close it and start fresh with a new PR; there's no technical review so far, so I think nothing would be lost.

@BurdetteLamar
Copy link
Contributor Author

Putting into new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants