Use rb_str_buf_new() to improve JSON.parse() performance with short string #452
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rb_str_buf_new
always performs allocation twice (atstr_alloc
andALLOC_N
).And the method does not allow embedded string even if the string is short enough.
Therefore, this PR uses
rb_str_new
instead to reduce the allocation with a short string.This PR will improve the performance by about 16%.
Environment
Before
After
Test code