Add option :allow_trailing_comma to JSON#parse #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice PR 🎉 I don't know if this will be accepted (since this goes beyond the stated goal of sticking to the RFC). If not, you should consider making a json5 parser. The one I know about has 500k downloads despite saying "Experimental JSON5 Ruby parser - DO NOT USE". The specs are already written too :-) |
|
Note: we already deviate from the RFC, for example with NaN, so I think this PR should be accepted. |
|
@hsbt: can we allow this feature? |
jspanjers
force-pushed
the
allow-trailing-comma
branch
from
bfd5778
to
66b288f
Compare
jspanjers
force-pushed
the
allow-trailing-comma
branch
from
5023f71
to
40c2a25
Compare
|
Hi there, I've rebased my feature branch to the current master to resolve some merge conflicts. Please review this pull request again and/or approve running the workflow to run the tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it would be really nice to support JSON arrays with trailing comma's!