Merge pull request #486 from Shopify/uk-call-super-in-included

Call `super` in `included` hook
flori · May 10, 2023 · a877630 · a877630
2 parents 248bc5b + cd8bbe5
commit a877630
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 0 deletions.
diff --git a/ext/json/ext/generator/generator.c b/ext/json/ext/generator/generator.c
@@ -478,6 +478,7 @@ static VALUE mFloat_to_json(int argc, VALUE *argv, VALUE self)
  */
 static VALUE mString_included_s(VALUE self, VALUE modul) {
     VALUE result = rb_funcall(modul, i_extend, 1, mString_Extend);
+    rb_call_super(1, &modul);
     return result;
 }
 

diff --git a/tests/json_generator_test.rb b/tests/json_generator_test.rb
@@ -391,6 +391,29 @@ def to_s; self; end
     end
   end
 
+  if defined?(JSON::Ext::Generator)
+    def test_string_ext_included_calls_super
+      included = false
+
+      Module.alias_method(:included_orig, :included)
+      Module.define_method(:included) do |base|
+        included_orig(base)
+        included = true
+      end
+
+      Class.new(String) do
+        include JSON::Ext::Generator::GeneratorMethods::String
+      end
+
+      assert included
+    ensure
+      if Module.private_method_defined?(:included_orig)
+        Module.alias_method(:included, :included_orig)
+        Module.remove_method(:included_orig)
+      end
+    end
+  end
+
   if defined?(Encoding)
     def test_nonutf8_encoding
       assert_equal("\"5\u{b0}\"", "5\xb0".force_encoding("iso-8859-1").to_json)