Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce @floating-ui/vue package #2034

Merged
merged 3 commits into from
Dec 14, 2022
Merged

Conversation

lozinsky
Copy link
Contributor

@lozinsky lozinsky commented Dec 12, 2022

This sources from the vue-floating-ui package. So far, it provides positioning only.

Next, I'd like to research the possibility of adding interactions to this package. But I'm not sure that I can keep compatibility with Vue 2. Because development of components with vue-demi is too hard vueuse/vue-demi#153.

@rollingversions
Copy link

rollingversions bot commented Dec 12, 2022

@floating-ui/vue (unreleased → 0.1.0)

New Features

  • Initial release

Packages With No Changes

The following packages have no user facing changes, so won't be released:

  • @floating-ui/core
  • @floating-ui/dom
  • @floating-ui/react
  • @floating-ui/react-dom
  • @floating-ui/react-native

Edit changelogs

@netlify
Copy link

netlify bot commented Dec 12, 2022

Deploy Preview for vibrant-gates-22c214 canceled.

Name Link
🔨 Latest commit a2d4f47
🔍 Latest deploy log https://app.netlify.com/sites/vibrant-gates-22c214/deploys/6399d2d78d4ae30009f1275c

@lozinsky lozinsky force-pushed the feat/vue branch 2 times, most recently from a1133ba to 5f9a29d Compare December 13, 2022 20:51
@atomiks
Copy link
Collaborator

atomiks commented Dec 14, 2022

Is this ready for review now? Thanks for this, it looks great 😄

Regarding the docs: for now, it should be commented out of the navigation. Once it's released on npm, I'll uncomment it (there will be a delay, so it won't exist).

@lozinsky lozinsky marked this pull request as ready for review December 14, 2022 13:00
@lozinsky
Copy link
Contributor Author

Is this ready for review now?

Yep 🙂

Regarding the docs: for now, it should be commented out of the navigation.

I've added hide: true.

@atomiks
Copy link
Collaborator

atomiks commented Dec 14, 2022

It looks great to me, but my Vue knowledge is very limited. Anyways, if there are any issues, people can file them 😄 In the meantime, we can start it as v0 major until a few months have passed with it being vetted by lots of usage, then bump it to v1

@atomiks atomiks merged commit d7aa94a into floating-ui:master Dec 14, 2022
@lozinsky lozinsky deleted the feat/vue branch December 15, 2022 08:29
@renatodeleao
Copy link

renatodeleao commented Dec 18, 2022

@lozinsky just want to thank you for doing this! Had to spin up my own package as well (floating-ui-x), because popular Vue community packages didn't follow the low-level approach of the original. It is so much better to take advantage of the popularity of this repository: more people, and more contributors = better code!

Developing Vue2/3 hybrid is indeed very painful when components are involved. Composables are "managable" from vue@>2.7.x but not sure if we should add that maintenance burden at this point (vue2 EOL next year). Been contributing to a few packages with that approach and my advice is that is just not worth it. It's a rabbit hole, especially when it comes to testing.

I will try to help with a few PRs for the interactions package, made very basic attempts here but never got to the publishing part. Feel free to peak and bring something here if valuable.

Cheers! ✌️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants