Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add ability to generate files in folders #10

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

ikstewa
Copy link
Contributor

@ikstewa ikstewa commented Apr 7, 2024

Adding a new feature flag prefix_schema_files_with_package which results in the schema files being generated in folders based on the package of the message.

Adding a new feature flag `prefix_schema_files_with_package` which
results in the schema files being generated in folders based on the
package of the message.
@ikstewa
Copy link
Contributor Author

ikstewa commented Apr 25, 2024

@dorner Do you have any interesting in accepting feature requests to this repo or should we just permanently fork?
We have a few additions which we needed for our use case if you would like to add more feature flags.

@dorner
Copy link
Member

dorner commented May 1, 2024

@ikstewa so sorry! I didn't have this repo as watched on my settings so I didn't see the original PR. I'm coming back from vacation but will take a look at these today.

Copy link
Member

@dorner dorner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good - had a couple of suggestions.

README.md Outdated Show resolved Hide resolved
@dorner
Copy link
Member

dorner commented May 7, 2024

@ikstewa tests are failing - can you rebase off main and make sure you rerun tests? You can use UPDATE_SNAPSHOTS=1to automatically update the fixtures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants