Preview: Add missing trait impls to make rustix/nix compile #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flba-eb
force-pushed
the
add_qnx_extra_traits
branch
from
fccb267
to
2028189
Compare
gh-tr
reviewed
Mar 27, 2023
gh-tr
reviewed
Mar 27, 2023
Tests pass on aarch64 (9775 tests) and x86-64 (9893 tests)
flba-eb
force-pushed
the
add_qnx_extra_traits
branch
2 times, most recently
from
27a465d
to
c0683f0
Compare
|
upstream pull request can be created |
|
See rust-lang#3273 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear @gh-tr, @samkearney and @Tom-Goring,
Before I make this PR public, feel free to have a look at these changes. They are required to make
rustix,nix,clap-4.2andctrlccompile.