Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some useful outputs to debug errors #112

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

brayanhenao
Copy link

@brayanhenao brayanhenao commented Jan 10, 2022

Add outputs to the download_file_http function:

  • Print the URL from which the file is downloaded.
  • Print the parameters of the HTTP Call.
  • In the case there is an HTTP error, print the status and the body of it.

@flavorjones
Copy link
Owner

Thank you! I've kicked off CI and will take a closer look tomorrow.

@flavorjones
Copy link
Owner

@brayanhenao Thanks again for proposing this. After reading, my primary concern is that HTTP proxy credentials may be leaked into a log when used.

Would you be open to dropping that line from this PR? Alternatively, this might be a good time to introduce a debug or verbose option to the constructor's **kwargs parameter. WDYT?

@flavorjones
Copy link
Owner

Bumping this, @brayanhenao did you want to try to make any of those changes?

@brayanhenao
Copy link
Author

Hi, @flavorjones I'll find some time this weekend/next week to make the change!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants