Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 'wbr' tag to safelist #212

Conversation

shota-yamashita
Copy link

@shota-yamashita shota-yamashita commented Jul 17, 2021

wbr tag is an empty HTML element, but not supported loofah so added it to support list.
ref: https://developer.mozilla.org/en-US/docs/Glossary/Empty_element

'wbr' tag is an empty HTML element, but not supported loofah so added it to support list.
ref: https://developer.mozilla.org/en-US/docs/Glossary/Empty_element
@shota-yamashita shota-yamashita marked this pull request as ready for review July 17, 2021 01:45
@flavorjones
Copy link
Owner

@shota-yamashita Thank you for this pull request! I've been taking some time off, but will take a look in the next day or so.

@flavorjones
Copy link
Owner

@shota-yamashita Unfortunately, VOID_ELEMENTS is unused and this tag should be added to ACCEPTABLE_ELEMENTS. I'm going to decline to merge this, but have submitted #213 to introduce support for wbr.

Thank you for taking the time to submit this, and for helping to make Loofah better!

@flavorjones
Copy link
Owner

Fixed in v2.11.0

@shota-yamashita shota-yamashita deleted the add_wbr_tag_to_safelist branch August 1, 2021 00:38
@shota-yamashita
Copy link
Author

@flavorjones

VOID_ELEMENTS is unused and this tag should be added to ACCEPTABLE_ELEMENTS

Oops, sorry. Thank you for fix it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants