Allow greater precision in values of shorthand css elements #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for this PR! I've merged it manually, and it will be in v2.3.0 which should drop in the next few days. |
|
v2.3.0 has been released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current regular expression for determining valid shorthand css is very restrictive and only allows 2 digits on the integer portion as well as the 2 digits in the fractional portion of a css value.
This PR increases the range of valid css values.
For example,
margin-left: 0.334pxwas previously sanitized by the html scrubber, but will now be preserved.I increased the number of allowed digits in the css value, but I'm honestly not convinced there should be a limit at all. That can be a point of discussion.
Issue: #149