Merge pull request #190 from ahorek/page_break

add page-break to safelist
flavorjones · Aug 26, 2020 · 490cd05 · 490cd05
2 parents 39e105c + a6d1d9e
commit 490cd05
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,11 @@
 
 ## unreleased
 
+### Features
+
+* Allow CSS properties `page-break-before`, `page-break-inside`, and `page-break-after`. [[#190](https://github.com/flavorjones/loofah/issues/190)] (Thanks, [@ahorek](https://github.com/ahorek)!)
+
+
 ### Fixes
 
 * Don't drop the `!important` rule from some CSS properties. [[#191](https://github.com/flavorjones/loofah/issues/191)] (Thanks, [@b7kich](https://github.com/b7kich)!)

diff --git a/lib/loofah/html5/safelist.rb b/lib/loofah/html5/safelist.rb
@@ -576,6 +576,9 @@ module SafeList
                                             "list-style-type",
                                             "max-width",
                                             "overflow",
+                                            "page-break-after",
+                                            "page-break-before",
+                                            "page-break-inside",
                                             "pause",
                                             "pause-after",
                                             "pause-before",

diff --git a/test/html5/test_sanitizer.rb b/test/html5/test_sanitizer.rb
@@ -379,6 +379,25 @@ def test_css_max_width
     assert_match %r/max-width/, sane.inner_html
   end
 
+  def test_css_page_break_after
+    html = '<div style="page-break-after:always;"></div>'
+    sane = Nokogiri::HTML(Loofah.scrub_fragment(html, :escape).to_xml)
+    assert_match %r/page-break-after:always/, sane.inner_html
+  end
+
+  def test_css_page_break_before
+    html = '<div style="page-break-before:always;"></div>'
+    sane = Nokogiri::HTML(Loofah.scrub_fragment(html, :escape).to_xml)
+    assert_match %r/page-break-before:always/, sane.inner_html
+  end
+
+  def test_css_page_break_inside
+    html = '<div style="page-break-inside:auto;"></div>'
+    sane = Nokogiri::HTML(Loofah.scrub_fragment(html, :escape).to_xml)
+    assert_match %r/page-break-inside:auto/, sane.inner_html
+  end
+
+
   def test_issue_90_slow_regex
     skip("timing tests are hard to make pass and have little regression-testing value")