pip: Add support for pyproject.toml #332
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TingPing
reviewed
Jan 5, 2023
| @@ -158,6 +169,16 @@ if opts.requirements_file: | |||
| except FileNotFoundError: | |||
| pass | |||
|
|
|||
| elif opts.pyproject_file: | |||
There was a problem hiding this comment.
Maybe it should error if both --requirements-file and --pyproject-file are given.
TingPing
reviewed
Jan 5, 2023
| @@ -28,6 +28,8 @@ parser.add_argument('--cleanup', choices=['scripts', 'all'], | |||
| help='Select what to clean up after build') | |||
| parser.add_argument('--requirements-file', '-r', | |||
| help='Specify requirements.txt file') | |||
| parser.add_argument('--pyproject-file', | |||
There was a problem hiding this comment.
Please rebase and update README.md to include this option.
Added: error thorwn if both --requirements-file and --pyproject-file are present Added: readme entry for --pyproject-file Fixed: readme entry for --requirements-file now warns about mutual exclusivity with --pyproject-file
|
Hello, I've added suggested improvements to the original PR, hope @JakobDev reacts to this soon! |
pyproject.toml improvements
|
I forget about this PR. Sorry for that. @ENDrain Thanks, I have now merged your PR |
|
@TingPing can you give this an update please? |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for reading dependencies from a ypproject.toml. On Python versions older than 3.11, you need to install tomli to use this feature.