Allow arch dependent packages #331
Conversation
Adds two new options to flatpak-pip-generator:
--arch-dependent-allow Allow arch dependent packages to be used
if no arch-independent package can be found.
flatpak#328
--arch-dependent-force Force arch dependent packages to always be used,
Useful if the Sdk doesn't have the tools to rebuild
the arch independent package
| parser.add_argument('--arch-dependent-allow', action='store_true', | ||
| help='Allow arch dependent packages to be used') | ||
| parser.add_argument('--arch-dependent-force', action='store_true', | ||
| help='Force arch dependent packages to be used') |
There was a problem hiding this comment.
README.md should have entries on these new parameters
There was a problem hiding this comment.
Question: shouldn't this have options to choose which arches are we targeting? Likes of arches-only and skip-arches?
Otherwise LGTM.
There was a problem hiding this comment.
Question: shouldn't this have options to choose which arches are we targeting? Likes of
arches-onlyandskip-arches?Otherwise LGTM.
That seems complicated and a future work. Currently, pip download cannot download a package for another arch unless you specify the whole pep 600 platform tag, eg. pip download --platform=manylinux_2_31_aarch64 --only-binary=:all: shiboken6
The tag varies from package to package due to the glibc version/package availability. There is also linux_aarch64/musllinux apart from manylinux.
There's also an issue where pip download doesn't handle legacy manylinux tag aliases too well pypa/pip#10760
It would need
a) Heuristics for guessing what value to pass to --platform
b) Modifying flatpak_cmd, based on (a)
I think for now it should be left to host/pip.
|
Hi @TingPing, can you please review this? A few latest submissions on Flathub are hitting the issue while trying to use pip-generator for pyside6/shiboken The only thing I don't like here is the generated manifest is usually copy-pasted without checking. If the flatpak is being built for multiple arches, the build will fail much later. But I don't know how to make that obvious here. |
Adds two new options to flatpak-pip-generator:
--arch-dependent-allow Allow arch dependent packages to be used
if no arch-independent package can be found.
#328
--arch-dependent-force Force arch dependent packages to always be used,
Useful if the Sdk doesn't have the tools to rebuild
the arch independent package