Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add GTK3 cups support #2

Merged
merged 1 commit into from
Jan 22, 2021
Merged

add GTK3 cups support #2

merged 1 commit into from
Jan 22, 2021

Conversation

tinywrkb
Copy link
Contributor

This tries to add the GTK3 cups backend taking advantage of the work that been already done for Chrome app.
I haven't tried building this, I'm letting the CI do it that, so this is still untested.
Closes #1.

@flathubbot
Copy link

Started test build 37250

@flathubbot
Copy link

Build 37250 failed

@flathubbot
Copy link

Started test build 37251

@flathubbot
Copy link

Build 37251 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/35856/net.cozic.joplin_desktop.flatpakref

@tinywrkb
Copy link
Contributor Author

Argh... still broken, I will try to see if I can solve it this later.

@tinywrkb tinywrkb closed this Jan 20, 2021
@tinywrkb tinywrkb reopened this Jan 22, 2021
@flathubbot
Copy link

Started test build 37382

@flathubbot
Copy link

Build 37382 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/35985/net.cozic.joplin_desktop.flatpakref

@tinywrkb
Copy link
Contributor Author

@catsout This is working as expected with the limitation that the GTK3 print dialog will only appear if there's a running CUPS daemon.
It seems safe to merge but I'll leave it to you.
That's it for me today.

@catsout catsout merged commit f20b82d into flathub:master Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Printing does not work
3 participants