Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

session: support regenerate ID for exsiting sessions #113

Merged
merged 2 commits into from
May 2, 2024
Merged

Conversation

unknwon
Copy link
Member

@unknwon unknwon commented May 1, 2024

Describe the pull request

Link to the issue: https://github.com/sourcegraph/sourcegraph-accounts/issues/193

Checklist

  • I agree to follow the Code of Conduct by submitting this pull request.
  • I have read and acknowledge the Contributing guide.
  • I have added test cases to cover the new code.

Co-authored-by: Vincent <evict@users.noreply.github.com>
Copy link

codecov bot commented May 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.79%. Comparing base (4a24cf9) to head (21ff3b2).

❗ Current head 21ff3b2 differs from pull request most recent head 03ff561. Consider uploading reports for the commit 03ff561 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #113      +/-   ##
==========================================
+ Coverage   75.23%   75.79%   +0.56%     
==========================================
  Files          10        2       -8     
  Lines         759      157     -602     
==========================================
- Hits          571      119     -452     
+ Misses        107       21      -86     
+ Partials       81       17      -64     

@evict
Copy link
Contributor

evict commented May 2, 2024

Nice! 👍

@unknwon unknwon merged commit 386f4b2 into main May 2, 2024
9 checks passed
@unknwon unknwon deleted the jc/regen-id branch May 2, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants