Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

router: support Routes accepting multiple strings as method #129

Merged
merged 2 commits into from Jun 1, 2022
Merged

Conversation

unknwon
Copy link
Member

@unknwon unknwon commented Jun 1, 2022

Describe the pull request

Link to the issue: #113

Checklist

  • I agree to follow the Code of Conduct by submitting this pull request.
  • I have read and acknowledge the Contributing guide.
  • I have added test cases to cover the new code.

Followup

  • Update docs on flamego.dev
  • Update docs on flamego.cn

@unknwon unknwon requested a review from a team June 1, 2022 10:32
@codecov
Copy link

codecov bot commented Jun 1, 2022

Codecov Report

Merging #129 (a1327d3) into main (fd701bd) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #129      +/-   ##
==========================================
+ Coverage   89.42%   89.49%   +0.06%     
==========================================
  Files          16       16              
  Lines        1135     1142       +7     
==========================================
+ Hits         1015     1022       +7     
  Misses         80       80              
  Partials       40       40              

@unknwon unknwon merged commit 7e355eb into main Jun 1, 2022
@unknwon unknwon deleted the jc/routes branch June 1, 2022 14:48
@unknwon
Copy link
Member Author

unknwon commented Jun 1, 2022

https://github.com/flamego/flamego/releases/tag/v1.4.0 has been tagged for this merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants