Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return_handler: support return values of ({string, []byte}, error) #118

Merged
merged 1 commit into from Apr 8, 2022

Conversation

unknwon
Copy link
Member

@unknwon unknwon commented Apr 8, 2022

Describe the pull request

Both (string, error) and ([]byte, error) are reasonable pairs of return values.

Link to the issue: #117

Checklist

  • I agree to follow the Code of Conduct by submitting this pull request.
  • I have read and acknowledge the Contributing guide.
  • I have added test cases to cover the new code.

Followups

  • Update docs to include all possible combinations of return values

@codecov
Copy link

codecov bot commented Apr 8, 2022

Codecov Report

Merging #118 (1f803c7) into main (4dcd516) will increase coverage by 0.07%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##             main     #118      +/-   ##
==========================================
+ Coverage   87.66%   87.74%   +0.07%     
==========================================
  Files          17       17              
  Lines        1135     1142       +7     
==========================================
+ Hits          995     1002       +7     
  Misses        101      101              
  Partials       39       39              

@unknwon unknwon linked an issue Apr 8, 2022 that may be closed by this pull request
1 task
@unknwon unknwon merged commit fede39f into main Apr 8, 2022
@unknwon unknwon deleted the jc/return-bytes-error branch April 8, 2022 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Returning a byte slice with an error outputs an empty HTTP body
2 participants