Add optional support for Zeroize #112
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeroize is the most popular crate for zeroizing memory after use. generic-array is the most popular crate for representing bytes in cryptographic implementations which can't use an allocator. Issues have been opened in RustCrypto about zeroizing instances of generic-array, for instance here: RustCrypto/hashes#87 However, sometimes you want to return generic-array from an API while also commiting it to be zeroized after use, because the caller might forget to do this on some code path. The natural way to do that in zeroize crate is the `Zeroizing` wrapper. However, `Zeroizing` cannot be used with `generic-array` unless `generic-array` implements the `Zeroize` trait. The easiest way to do that is create an optional dependency on `Zeroize` and put the implementation in a conditionally-compiled module, as we did in this commit.
|
This feature has been added in |
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zeroize is the most popular crate for zeroizing memory after use.
generic-array is the most popular crate for representing bytes in
cryptographic implementations which can't use an allocator.
Issues have been opened in RustCrypto about zeroizing instances of
generic-array, for instance here:
RustCrypto/hashes#87
However, sometimes you want to return generic-array from an API
while also commiting it to be zeroized after use, because the caller
might forget to do this on some code path. The natural way to do that
in zeroize crate is the
Zeroizingwrapper. However,Zeroizingcannot be used with
generic-arrayunlessgeneric-arrayimplementsthe
Zeroizetrait.The easiest way to do that is create an optional dependency on
Zeroizeand put the implementation in a conditionally-compiledmodule, as we did in this commit.