Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch openai to openai-edge #66

Merged
merged 30 commits into from
Jun 18, 2023
Merged

Conversation

NickHeiner
Copy link
Contributor

@NickHeiner NickHeiner commented Jun 17, 2023

Axios doesn't appear to support streaming in the browser, and since we want AI.JSX to be able to run in browser, that's a no-go for us.

Loom showing streaming in the browser

We still don't stream the UI demos (e.g. recipe builder) because filling in UI pieces bit-by-bit could be worse than buffering.

The other approach would have been to do something like langchain/src/util/axios-fetch-adapter.js..

@vercel
Copy link

vercel bot commented Jun 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai-jsx-create-react-app-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 18, 2023 0:26am
ai-jsx-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 18, 2023 0:26am

@NickHeiner NickHeiner changed the title WIP Switch openai to openai-edge Switch openai to openai-edge Jun 17, 2023
@@ -125,6 +125,7 @@
"react": "^16.8.0 || ^17.0.0 || ^18.0.0"
},
"dependencies": {
"@nick.heiner/openai-edge": "1.0.1-7",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did we need to fork openai-edge?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops – I thought I'd left a note about this somewhere: dan-kwiat/openai-edge#6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants