Improve performance of String::from_str_in
#231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI should pass if rebased on top of #232. |
fitzgen
approved these changes
Feb 14, 2024
overlookmotel
force-pushed
the
faster-from-str-in
branch
from
33d0398
to
33f6ea8
Compare
|
Rebased on top of #229 (which is now rebased on top of main). Have done it that way as otherwise there's merge conflicts. Hope that's OK. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I investigated performance of
String::from_str_in. Turns out that even afterString::push_stris optimized (#229), the compiler does not figure out that bounds checks and various calculations can be elided.So this change makes
from_str_inabout 18% faster for small strings.PR includes a benchmark to demonstrate this.
Built on top of #229. If you're willing to merge, please merge that one first.
Sorry for sudden barrage of issues and PRs!