Annotate Allocator methods with #[inline]
#223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Mind bumping the MSRV to 1.65.0 while you're here? It looks like |
|
I ran into the MSRV thing with #224 as well. I'll submit a separate PR that fixes that. |
|
#225 merged so this can be rebased on that and then we can merge it. |
These methods were not annotated with `#[inline]`, meaning they will not be inlined into client crates unless they enable LTO
Kmeakin
force-pushed
the
allocator-methods-inline
branch
from
2fb5324
to
e6a7eb0
Compare
|
Ready to merge. Sorry it wasn't done sooner, I'd forgotten this patch was pending. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These methods were not annotated with
#[inline], meaning they will not be inlined into client crates unless they enable LTO