Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clippy: Allow large_enum_variant in tests. #218

Closed
wants to merge 1 commit into from
Closed

clippy: Allow large_enum_variant in tests. #218

wants to merge 1 commit into from

Conversation

waywardmonkeys
Copy link
Contributor

2 instances of this enum already had this, but it was missing from these two.

@waywardmonkeys
clippy: Allow large_enum_variant in tests.
dd2a720 
2 instances of this enum already had this, but it was missing
from these two.
fitzgen
fitzgen reviewed Sep 25, 2023
View reviewed changes
Copy link
Owner

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! However, I don't personally use clippy because I find that the suggestions are not always useful / are sometimes too opinionated, and I would rather not litter the code base with annotations like these just to satisfy it.

@fitzgen fitzgen closed this Sep 25, 2023
@fitzgen
Copy link
Owner

fitzgen commented Sep 25, 2023

I'll remove the existing annotations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fitzgen fitzgen fitzgen left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@waywardmonkeys @fitzgen