Implement std::io::Write
for Vec<'bump, u8>
#216
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @fitzgen
Here is my attempt to implement
std::io::Write
forVec<'bump, u8>
I believe there are other common traits like this we could implement for some collections but I have left that for another time (but I 'd be happy to contribute those).
I have a few questions:
std
feature does not do anything on its own, it's currently only useful if you also have thecollections
feature enabled too. I think it's fine but I wondered if having instead acollections-std
feature depending oncollections
would be better? Although thestd
feature is pretty standard across the community.Fixes #215