Fix chunk_capacity to return the remaining capacity, not the total #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`chunk_capacity` is documented as returning "the remaining capacity in the current chunk", but actually returns the *total* capacity for the current chunk. (Arguably, the actual behavior is itself totally sensible, and this is a documentation bug, though in that case I would propose adding a new function that returns the remaining capacity. I would like it for debugging/measurement purposes.)
aljazerzen
pushed a commit
to edgedb/edgedb
that referenced
this pull request
Jul 11, 2023
Unfortunately it requires fitzgen/bumpalo#209 to be useful
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chunk_capacityis documented as returning "the remaining capacity in the current chunk", but actually returns the total capacity for the current chunk.(Arguably, the actual behavior is itself totally sensible, and this is a documentation bug, though in that case I would propose adding a new function that returns the remaining capacity. I would like it for debugging/measurement purposes.)