Skip to content

Commit

Permalink
Fixing minimizer column ordering
Browse files Browse the repository at this point in the history
  • Loading branch information
wathen committed Sep 4, 2020
1 parent 715454f commit 95e6cff
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 22 deletions.
3 changes: 2 additions & 1 deletion fitbenchmarking/core/fitting_benchmarking.py
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,8 @@ def benchmark(options, data_dir):

for keys, minimzers in unselected_minimzers.items():
minimizers_all = options.minimizers[keys]
options.minimizers[keys] = list(set(minimizers_all) - set(minimzers))
diff = set(minimizers_all) - set(minimzers)
options.minimizers[keys] = [x for x in minimizers_all if x in diff]

# Used to group elements in list by name
results_dict = defaultdict(list)
Expand Down
25 changes: 4 additions & 21 deletions fitbenchmarking/core/tests/test_fitting_benchmarking_benchmark.py
Original file line number Diff line number Diff line change
Expand Up @@ -153,30 +153,13 @@ def test_check_unselected_minimizers(self, loop_over_benchmark_problems):
# run shared test and see if it match expected
expected_minimzers = copy.copy(self.all_minimzers)
for keys, minimzers in expected_unselected_minimzers.items():
expected_minimzers[keys] = \
list(set(expected_minimzers[keys]) - set(minimzers))
diff = set(expected_minimzers[keys]) - set(minimzers)
expected_minimzers[keys] = [x for x in expected_minimzers[keys]
if x in diff]

self.shared_tests(expected_names, expected_unselected_minimzers,
expected_minimzers)

# <<<<<<< HEAD
# @mock.patch('{}.loop_over_benchmark_problems'.format(FITTING_DIR))
# def test_check_no_results_produced(self, loop_over_benchmark_problems):
# """
# Checks benchmarking raises an error when no results are produced
# """

# results = []
# problem_fails = []
# expected_unselected_minimzers = {"scipy": []}
# loop_over_benchmark_problems.return_value = \
# (results, problem_fails, expected_unselected_minimzers)
# with self.assertRaises(NoResultsError):
# _, _, _ = \
# benchmark(self.options, self.default_parsers_dir)

# =======
# >>>>>>> 723b27b2... Updating first example docs (#604)


if __name__ == "__main__":
unittest.main()

0 comments on commit 95e6cff

Please sign in to comment.