Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ignore #430

Open
wants to merge 26 commits into
base: main
Choose a base branch
from
Open

Update ignore #430

wants to merge 26 commits into from

Conversation

fisker
Copy link
Owner

@fisker fisker commented May 29, 2020

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/pr-XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

Try the playground for this PR

@pull-assistant
Copy link

pull-assistant bot commented May 29, 2020

Score: 0.99

Best reviewed: commit by commit


Optimal code review plan (7 warnings)

Update `ignore` to v5

yarn.lock 50% changes removed in Merge remote-trackin...

fix logic

src/cli/util.js 80% changes removed in Merge branch 'master...

src/common/get-file-info.js 83% changes removed in Fix

     make ESLint happy

     Apply suggestions from code review

Merge remote-tracking branch 'remotes/upstream/master' into update-ign...

package.json 67% changes removed in Merge branch 'master...

scripts/build/bundler.js 75% changes removed in Merge branch 'master...

yarn.lock 61% changes removed in Merge branch 'master...

     update yarn.lock

     Update src/cli/util.js

Merge branch 'master' into update-ignore

...resolve-config-editorconfig.js 55% changes removed in Merge branch 'master...

src/common/internal-plugins.js 45% changes removed in Merge branch 'master...

...elog_unreleased/vue/pr-8023.md 48% changes removed in Merge branch 'fix-ge...

Merge branch 'master' into update-ignore

package.json 60% changes removed in Merge branch 'master...

     Fix

     Add emoji test on api

     Add failed tests

     Fix the bug

     Add changelog

Merge branch 'fix-get-file-info-file-path' into update-ignore

...workflows/dev-package-test.yml 50% changes removed in Merge branch 'master...

...github/workflows/prod-test.yml 50% changes removed in Merge branch 'master...

.github/workflows/lint.yml 50% changes removed in Merge branch 'master...

package.json 50% changes removed in Merge branch 'master...

     Merge branch 'master' into update-ignore

     Merge branch 'master' into update-ignore

     Build(deps): Bump @angular/compiler (#8641)

ESLint: enable `import/order` (#8635)

src/main/core.js 44% changes removed in Merge branch 'master...

     Merge branch 'master' into update-ignore

Powered by Pull Assistant. Last update f54efa3 ... 9b1f210. Read the comment docs.

@fisker fisker force-pushed the update-ignore branch 5 times, most recently from fb224a9 to 5ac6b81 Compare June 12, 2020 08:14
Base automatically changed from master to main January 25, 2021 02:31
# Conflicts:
#	package.json
#	src/cli/util.js
#	src/common/get-file-info.js
#	tests_integration/__tests__/__snapshots__/file-info.js.snap
#	tests_integration/__tests__/file-info.js
#	tests_integration/__tests__/ignore-emoji.js
#	yarn.lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant