Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete cargo check bin targets like build #10499

Merged

Conversation

ian-h-chamberlain
Copy link
Contributor

Description

Since check operates on basically the same things as build, it makes sense to complete binary targets the same way (i.e. tests, bins, examples)

Relates to #8429 — these completions already existed, just were being ignored for check.

Before
ianchamberlain@MacBook-Pro ~/D/D/fish-shell (fix/cargo-check-completions)> complete -C 'cargo check --bin '
benchmarks/
BSDmakefile
build.rs
build_tools/
Cargo.lock
Cargo.toml
CHANGELOG.rst
cmake/
CMakeLists.txt
CODE_OF_CONDUCT.md
CONTRIBUTING.rst
COPYING
debian/
docker/
Dockerfile
doc_internal/
doc_src/
etc/
fish.desktop
fish.pc.in
fish.png
fish.spec.in
GNUmakefile
osx/
po/
README.rst
share/
src/
target/
tests/

After:

ianchamberlain@MacBook-Pro ~/D/D/fish-shell (fix/cargo-check-completions)> complete -C 'cargo check --bin '
fish
fish_indent
fish_key_reader

TODOs:

  • Changes to fish usage are reflected in user documentation/manpages.
  • Tests have been added for regressions fixed
  • User-visible changes noted in CHANGELOG.rst

Are any of these needed for such a small completion fix? Also, is this something that would make sense to backport to 3.7 or something (not sure what the release plan / versioning scheme is looking like at this point)?

Since `check` operates on basically the same things as `build`, it makes
sense to complete binary targets the same way (i.e. tests, bins, examples)
@mqudsi mqudsi merged commit 1462da3 into fish-shell:master May 17, 2024
6 of 7 checks passed
@mqudsi
Copy link
Contributor

mqudsi commented May 17, 2024

Merged with thanks.

@ian-h-chamberlain ian-h-chamberlain deleted the fix/cargo-check-completions branch May 17, 2024 17:41
@zanchey zanchey added this to the fish next-3.x milestone May 18, 2024
@zanchey
Copy link
Member

zanchey commented May 18, 2024

No release note required, and can't see us doing another 3.7 at this stage - better to try and get 3.8 out.

@mqudsi
Copy link
Contributor

mqudsi commented May 18, 2024

@zanchey sorry, I keep forgetting to label these when I go through them quickly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants