This repository has been archived by the owner on Sep 21, 2021. It is now read-only.
Allow batched worker tasks and generated sourcemap range lookup #1029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loganfsmyth
commented
Apr 12, 2018
| } | ||
| })).then(results => { | ||
| self.postMessage({ id, results }); | ||
| }); | ||
| }; | ||
| } | ||
|
|
There was a problem hiding this comment.
None of this updates streamingWorkerHandler below here because as far as I can tell it is already incompatible with the existing .task function in the general case. .task only listens for a single message, so it can't be used alongside streamingWorkerHandler as is.
Closed
59 tasks
… task calls into a single postMessage, for performance.
loganfsmyth
force-pushed
the
sourcemap-debounced-dispatch
branch
from
a18cb0c
to
9df6c4a
Compare
jasonLaster
approved these changes
Apr 12, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Associated Issue: firefox-devtools/debugger#5561
Summary of Changes