This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
Re-apply the non-breaking pieces reverted in #6112 #6170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n with decorators.
jasonLaster
pushed a commit
that referenced
this pull request
Apr 30, 2018
jasonLaster
pushed a commit
that referenced
this pull request
Apr 30, 2018
jasonLaster
pushed a commit
that referenced
this pull request
Apr 30, 2018
jasonLaster
pushed a commit
that referenced
this pull request
May 7, 2018
jasonLaster
pushed a commit
that referenced
this pull request
May 8, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs Issue: #5561
Summary of Changes
The error in #6112 is due to the generic declaration mapping being too broad in the general case, leading to false-positive binding matches. I'll re-apply those excluded commits in a PR next week once I can get them to only apply in more specific cases that won't lead to false-positive binding matches.