Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

[Scopes] Show "optimized out" instead of "unmapped" when resolving import declarations #5984

Merged
merged 2 commits into from Apr 16, 2018
Merged

[Scopes] Show "optimized out" instead of "unmapped" when resolving import declarations #5984

merged 2 commits into from Apr 16, 2018

Conversation

loganfsmyth
Copy link
Contributor

@loganfsmyth loganfsmyth commented Apr 16, 2018 •
edited

Refs Issue: #5561

Summary of Changes

  • Fixes the binding filtering to more strict
  • If an optimized-out value is encountered while resolving import bindings, use it if no better value is found

@loganfsmyth loganfsmyth mentioned this pull request Apr 16, 2018
Closed
59 tasks
@darkwing darkwing merged commit fc67314 into firefox-devtools:master Apr 16, 2018
@loganfsmyth loganfsmyth deleted the unmapped-import-fix branch April 16, 2018 20:36
jasonLaster pushed a commit that referenced this pull request Apr 18, 2018
@loganfsmyth @jasonLaster
[Scopes] Show "optimized out" instead of "unmapped" when resolving im…
57a5204 
…port declarations (#5984)

* Use exclusive ranges.

* Handle multiple optimized-out import bindings as optimized-out, not unmapped.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jasonLaster jasonLaster jasonLaster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@loganfsmyth @jasonLaster @darkwing