[scopes] Batch generated locations #5892

jasonLaster · 2018-04-09T23:25:25Z

Fixes Issue: #5561

Summary of Changes

This is an attempt to speedup the mapping logic by consolidating the source map location fetching.
I dont know if this was the slowest path though... I do know that this is faster when there are 19K locations...

The first thing here is the refactor of mapScopes, which i did to learn the layout of the code...

The code also relies on a new batch pr.

Here's a new profile after the fact

Here's an STR:

update the custom debugger page in talos to have a hit button here

+++ b/testing/talos/talos/tests/devtools/addon/content/pages/custom/debugger/index.html
@@ -1 +1,15 @@
-<!DOCTYPE html><html lang="en"><head><meta charset="utf-8"><meta name="viewport" content="width=device-width,initial-scale=1,shrink-to-fit=no"><meta name="theme-color" content="#000000"><link rel="manifest" href="./manifest.json"><title>React App</title></head><body><noscript>You need to enable JavaScript to run this app.</noscript><div id="root"></div><script type="text/javascript" src="./static/js/main.js"></script></body></html>
+<!DOCTYPE html>
+<html lang="en">
+ <head>
+         <meta charset="utf-8">
+         <meta name="viewport" content="width=device-width,initial-scale=1,shrink-to-fit=no">
+         <meta name="theme-color" content="#000000"><link rel="manifest" href="./manifest.json">
+         <title>React App</title>
+ </head>
+ <body>
+         <noscript>You need to enable JavaScript to run this app.</noscript>
+         <div id="root"></div>
+         <script type="text/javascript" src="./static/js/main.js"></script>
+         <button onclick="hitBreakpoint()">hitBreakpoint</button>
+ </body>
+</html>

set a local server python -m SimpleHTTPServer 3000
debug the page with the launchpad
add a breakpoint at App.js#22
step in
observe scopes are loading for awhile

loganfsmyth · 2018-04-10T17:33:35Z

src/utils/pause/mapScopes/generateClientScope.js

@@ -0,0 +1,68 @@
+export function generateClientScope(


Missing // @flow

loganfsmyth · 2018-04-10T17:33:48Z

src/utils/pause/mapScopes/isReliableScope.js

@@ -0,0 +1,27 @@
+/**


Missing // @flow

loganfsmyth · 2018-04-10T17:50:34Z

src/utils/pause/mapScopes/findGeneratedBindingFromPosition.js

-  const end = await sourceMaps.getGeneratedLocation(pos.end, source);
+  // console.log(`> getting locations ${pos.start.line} ${pos.end.line}`);
+  const start = getGeneratedLocation(pos.start, generatedLocations);
+  const end = getGeneratedLocation(pos.end, generatedLocations);


We may want to delay this, because this is the logic I'm already going to be changing to updating how the ranges work. Maybe it would make more sense for me to make that a batched lookup?

that works!

jasonLaster · 2018-04-10T21:22:09Z

logan will go a different direction

jasonLaster added 2 commits April 9, 2018 17:33

[scopes] refactor mapScopes

b2f8438

batch getting generated locations

3c86ad4

jasonLaster force-pushed the batch-generated-locs branch from 9dd93a8 to 3c86ad4 Compare April 10, 2018 00:45

loganfsmyth reviewed Apr 10, 2018

View reviewed changes

src/utils/pause/mapScopes/generateClientScope.js

@@ -0,0 +1,68 @@

export function generateClientScope(

Copy link

Contributor

loganfsmyth Apr 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing // @flow

loganfsmyth reviewed Apr 10, 2018

View reviewed changes

src/utils/pause/mapScopes/isReliableScope.js

@@ -0,0 +1,27 @@

/**

Copy link

Contributor

loganfsmyth Apr 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing // @flow

loganfsmyth reviewed Apr 10, 2018

View reviewed changes

jasonLaster closed this Apr 10, 2018

loganfsmyth mentioned this pull request Apr 10, 2018

[scopes] Optimize the performance of looking up the generated binding for a mapped original location #5919

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[scopes] Batch generated locations #5892

[scopes] Batch generated locations #5892

jasonLaster commented Apr 9, 2018 •

edited

loganfsmyth Apr 10, 2018

loganfsmyth Apr 10, 2018

loganfsmyth Apr 10, 2018

jasonLaster Apr 10, 2018

jasonLaster commented Apr 10, 2018

[scopes] Batch generated locations #5892

[scopes] Batch generated locations #5892

Conversation

jasonLaster commented Apr 9, 2018 • edited

Summary of Changes

loganfsmyth Apr 10, 2018

Choose a reason for hiding this comment

loganfsmyth Apr 10, 2018

Choose a reason for hiding this comment

loganfsmyth Apr 10, 2018

Choose a reason for hiding this comment

jasonLaster Apr 10, 2018

Choose a reason for hiding this comment

jasonLaster commented Apr 10, 2018

jasonLaster commented Apr 9, 2018 •

edited