Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

[Scopes] Avoid exceptions when import bindings are optimized away. #5722

Merged
merged 1 commit into from Mar 20, 2018
Merged

[Scopes] Avoid exceptions when import bindings are optimized away. #5722

merged 1 commit into from Mar 20, 2018

Conversation

loganfsmyth
Copy link
Contributor

Refs Issue: #5561

Summary of Changes

  • More carefully check the Grip objects before trying to get properties from them

jasonLaster
jasonLaster approved these changes Mar 19, 2018
View reviewed changes
Copy link
Contributor

@jasonLaster jasonLaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the comments and the tests.

I feel better about this code now than before, which is impressive given that we’re handling some difficult cases

@jasonLaster jasonLaster merged commit 2fe01ff into firefox-devtools:master Mar 20, 2018
jasonLaster pushed a commit that referenced this pull request Mar 21, 2018
@loganfsmyth @jasonLaster
[Scopes] Avoid exceptions when import bindings are optimized away. (#…
dbdbdf3 
…5722)
@loganfsmyth loganfsmyth deleted the optimized-import-bindings branch March 21, 2018 18:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jasonLaster jasonLaster jasonLaster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@loganfsmyth @jasonLaster