This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
Exclude Flowtype bindings from original scope list. #5692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonLaster
reviewed
Mar 16, 2018
| "Module", | ||
| ["aConst", '"a-const"'], | ||
| "root()" | ||
| ]); |
jasonLaster
reviewed
Mar 16, 2018
| } else if ( | ||
| t.isImportDeclaration(node) && | ||
| (!node.importKind || node.importKind === "value") | ||
| ) { |
There was a problem hiding this comment.
do we also want a unit test for this too?
it should be simpler and would give us some quicker feedback than the mochitest, which is also helpful but less direct
darkwing
force-pushed
the
original-scope-flowtype
branch
from
39351d9
to
e6bf166
Compare
|
Hmm, maybe this is legit |
loganfsmyth
force-pushed
the
original-scope-flowtype
branch
from
e6bf166
to
10118b9
Compare
loganfsmyth
force-pushed
the
original-scope-flowtype
branch
from
10118b9
to
f00a495
Compare
jasonLaster
pushed a commit
that referenced
this pull request
Mar 21, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs Issue: #5561
Summary of Changes
Test Plan
Tell us a little a bit about how you tested your patch.